[multimod] Remove tag push, print instead. #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 58.26% // Head: 58.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 58.26% 58.17% -0.10%
==========================================
Files 44 44
Lines 1953 1927 -26
==========================================
- Hits 1138 1121 -17
+ Misses 685 680 -5
+ Partials 130 126 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mx-psi
reviewed
Nov 28, 2022
mx-psi
approved these changes
Nov 28, 2022
|
@bogdandrutu maybe you want to review this? |
bogdandrutu
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
--pushflag onmultimod tag. As shown in issue #177pushrequired additional authentication to be set up since it did not natively read git credentials from the environment. Multiple options were discussed in #177. This PR implements the last suggestion which prints all tags separated by a newline. This--print-tagsoption can then be worked into existing repositories release process.The
pushcode has been removed from multimod. I believe theos.execoption is still possible but I have not had time to address it. This option provides a quick win while also removing bugged code. I suggest we reopen #157 which can be assigned and investigated in the future.Fixes #177