Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chloggen] Use go embed to embed the template file #225

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 19, 2023

Fixes #224

@atoulme atoulme requested review from a team and dmitryax January 19, 2023 00:02
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 58.85% // Head: 58.86% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (b74af7c) compared to base (0272a80).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   58.85%   58.86%   +0.01%     
==========================================
  Files          44       44              
  Lines        2000     1991       -9     
==========================================
- Hits         1177     1172       -5     
+ Misses        692      689       -3     
+ Partials      131      130       -1     
Impacted Files Coverage Δ
chloggen/internal/chlog/context.go 69.56% <ø> (+6.23%) ⬆️
chloggen/internal/chlog/summary.go 91.66% <100.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

chloggen/internal/chlog/summary.go Outdated Show resolved Hide resolved
chloggen/internal/chlog/summary.go Outdated Show resolved Hide resolved
atoulme and others added 2 commits January 18, 2023 16:40
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <lazy@splunk.com>
@atoulme
Copy link
Contributor Author

atoulme commented Jan 19, 2023

ah bleh. I'll fix.

@atoulme
Copy link
Contributor Author

atoulme commented Jan 19, 2023

codecov says:

[2023-01-19T01:18:03.580Z] ['verbose'] Passed token was 0 characters long

I think something is broken with the codecov secret.

@mx-psi mx-psi merged commit 26fd78b into open-telemetry:main Jan 19, 2023
@atoulme atoulme mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chloggen panics on execution
5 participants