Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chloggen] Disallow whitespace-only values #239

Merged

Conversation

djaglowski
Copy link
Member

Resolved #164

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7df0c50) 60.22% compared to head (3be09a1) 60.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   60.22%   60.22%           
=======================================
  Files          47       47           
  Lines        2172     2172           
=======================================
  Hits         1308     1308           
  Misses        721      721           
  Partials      143      143           
Impacted Files Coverage Δ
chloggen/internal/chlog/entry.go 76.92% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review January 30, 2023 20:48
@djaglowski djaglowski requested review from a team and Aneurysm9 January 30, 2023 20:48
@djaglowski
Copy link
Member Author

Closing as duplicate of #165

@djaglowski djaglowski closed this Jan 30, 2023
@pellared
Copy link
Member

@djaglowski If you want you can reopen it as #165 got stale and I closed it.

@djaglowski djaglowski reopened this Jun 20, 2023
@pellared pellared merged commit 4c9b69d into open-telemetry:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation for strings containing only spaces in component and note is missing for chloggen
3 participants