Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Cleanup chloggen globalCfg usage #376

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

djaglowski
Copy link
Member

This is a subset of #372 which will make that PR easier to review.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (4216b12) 62.08% compared to head (053dfeb) 62.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
- Coverage   62.08%   62.07%   -0.02%     
==========================================
  Files          48       48              
  Lines        2345     2344       -1     
==========================================
- Hits         1456     1455       -1     
  Misses        741      741              
  Partials      148      148              
Files Changed Coverage Δ
chloggen/cmd/root.go 63.88% <100.00%> (-0.98%) ⬇️
chloggen/internal/chlog/entry.go 81.53% <100.00%> (ø)
chloggen/internal/config/config.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski djaglowski marked this pull request as ready for review July 25, 2023 19:03
@djaglowski djaglowski requested review from a team and mx-psi July 25, 2023 19:03
@djaglowski djaglowski merged commit 37d80b2 into open-telemetry:main Jul 25, 2023
9 checks passed
@djaglowski djaglowski deleted the chloggen-global-cfg branch July 25, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants