Remove checkdoc #380
Merged
Remove checkdoc #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the deprecated checkdoc in favor of checkfile (open-telemetry#348). This PR also adds checkfile to `versions.yaml` which wasn't done in the previous PR. Issue: open-telemetry#378
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 62.70% 62.39% -0.32%
==========================================
Files 48 49 +1
Lines 2392 2404 +12
==========================================
Hits 1500 1500
- Misses 743 755 +12
Partials 149 149
☔ View full report in Codecov by Sentry. |
MrAlias
approved these changes
Jul 27, 2023
songy23
approved these changes
Jul 28, 2023
Closed
mackjmr
added a commit
to mackjmr/opentelemetry-lambda
that referenced
this pull request
Aug 1, 2023
checkdoc will be removed in the next release open-telemetry/opentelemetry-go-build-tools#380 in favor of checkfile. Here, it doesn't seem like checkdoc is used at all so removing altogether. Issue: open-telemetry/opentelemetry-go-build-tools#349
mackjmr
added a commit
to mackjmr/experimental-arrow-collector
that referenced
this pull request
Aug 1, 2023
checkdoc will be removed in favor of checkfile: open-telemetry/opentelemetry-go-build-tools#380 Issue: open-telemetry/opentelemetry-go-build-tools#349
codeboten
pushed a commit
to open-telemetry/opentelemetry-lambda
that referenced
this pull request
Aug 15, 2023
checkdoc will be removed in the next release open-telemetry/opentelemetry-go-build-tools#380 in favor of checkfile. Here, it doesn't seem like checkdoc is used at all so removing altogether. Issue: open-telemetry/opentelemetry-go-build-tools#349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated checkdoc in favor of checkfile (#348).
This PR also adds checkfile to
versions.yamlwhich wasn't done in the previous PR.Issue: #378