Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chloggen] Update permissions of the generated files #457

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

pantuza
Copy link
Contributor

@pantuza pantuza commented Dec 8, 2023

Contributions

When you use chloggen new --config template.yaml --filename contribution.yaml the generated file
has 0755 permission. Thus, it generates yaml files with Execution permission.

Maybe you folks have a purpose for doing it. Although, I didn't find any explanation for it.
Therefore, from my perspective, it seems to be a "bug". Please close this PR in case I am wrong.

This Pull Request updates the code in order to use the permission 0644 where we have:

  • User: Write, Read, No Execution
  • Group: No Write, Read, No Execution
  • Others: No Write, Read, No Execution

Context

I was writing this Pull Request to Open Telemetry Collectors and realized that this tool (chloggen) was creating executable files under .chloggen/directory which seemed strange to me.

@pantuza pantuza requested review from a team and Aneurysm9 December 8, 2023 22:15
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2aabfff) 63.65% compared to head (ba2b497) 63.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files          39       39           
  Lines        2259     2259           
=======================================
  Hits         1438     1438           
  Misses        677      677           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared merged commit e7cf383 into open-telemetry:main Dec 8, 2023
10 checks passed
Copy link

@renanbastos93 renanbastos93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pellared pellared mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants