Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multimod: Fix to log 'Using versioning file' and 'Successfully deleted module tags' to stderr instead of stdout #507

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

@pellared pellared requested review from a team and jpkrohling February 26, 2024 18:32
@pellared
Copy link
Member Author

CC @open-telemetry/collector-approvers

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.76%. Comparing base (5655634) to head (05fe1b1).

Files Patch % Lines
multimod/internal/tag/tag.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files          39       39           
  Lines        2274     2274           
=======================================
  Hits         1450     1450           
  Misses        679      679           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pellared pellared changed the title multimod: Fix to log 'Using versioning file' to stderr instead of stdout multimod: Fix to log 'Using versioning file' and 'Successfully deleted module tags' to stderr instead of stdout Feb 26, 2024
@pellared
Copy link
Member Author

Bump @open-telemetry/collector-maintainers

@pellared pellared merged commit fa341a2 into open-telemetry:main Feb 29, 2024
11 of 12 checks passed
@pellared pellared deleted the multimod-using-stderr branch March 1, 2024 17:36
@pellared pellared mentioned this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants