Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multimod] Improve error message when Go proxy misbehaves #610

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 8, 2024

  • Check status code of reply from Go proxy and fail if status code is 4xx or 5xx.
  • Add information about package and tag that caused the failure

@mx-psi mx-psi force-pushed the mx-psi/better-multimod-errors branch from 135dbc3 to be1f84f Compare October 8, 2024 20:55
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.10%. Comparing base (06a3912) to head (be1f84f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   53.03%   53.10%   +0.06%     
==========================================
  Files          51       51              
  Lines        2255     2258       +3     
==========================================
+ Hits         1196     1199       +3     
  Misses        912      912              
  Partials      147      147              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi marked this pull request as ready for review October 8, 2024 21:00
@mx-psi mx-psi requested review from a team as code owners October 8, 2024 21:00
@mx-psi mx-psi merged commit da7f4ad into open-telemetry:main Oct 9, 2024
12 checks passed
@mx-psi mx-psi deleted the mx-psi/better-multimod-errors branch October 9, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants