Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global trace forwarding implementation #406

Merged
merged 7 commits into from
Jan 2, 2020
Merged

Global trace forwarding implementation #406

merged 7 commits into from
Jan 2, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 31, 2019 •
edited
Loading

Implements deferred initialization for trace resources registered before the first Trace SDK is installed.

This implements the behavior specified in open-telemetry/oteps#74.

Resolves #398.

@lizthegrey
Copy link
Member

Remove the WIP tag when you're ready for us to review.

@MrAlias MrAlias changed the title [WIP] Global trace forwarding implementation Global trace forwarding implementation Dec 31, 2019
@lizthegrey
Copy link
Member

Description should say trace SDK, not meter SDK right? this is a parallel pull to #392 if I understand correctly, and @jmacd should take lead on reviewing this

@lizthegrey lizthegrey added blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made pkg:SDK Related to an SDK package labels Jan 1, 2020
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 1, 2020

Thanks for catching that @lizthegrey , I've updated the description.

@jmacd jmacd added area:trace Part of OpenTelemetry tracing and removed blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made labels Jan 2, 2020
jmacd
jmacd approved these changes Jan 2, 2020
View reviewed changes
api/global/internal/trace.go Outdated Show resolved Hide resolved
lizthegrey
lizthegrey suggested changes Jan 2, 2020
View reviewed changes
api/global/internal/trace.go Outdated Show resolved Hide resolved
api/global/internal/trace.go Show resolved Hide resolved
@lizthegrey lizthegrey merged commit bb4f7fa into open-telemetry:master Jan 2, 2020
@MrAlias MrAlias deleted the global-trace branch January 2, 2020 22:01
huikang referenced this pull request in huikang/opentelemetry-go Jan 3, 2020
@MrAlias
Global trace forwarding implementation (#406)
dd8249e 
* Global trace forwarding implementation according to open-telemetry/oteps#74
@MrAlias MrAlias mentioned this pull request Feb 11, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizthegrey lizthegrey lizthegrey approved these changes

@jmacd jmacd jmacd approved these changes

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@rghetia rghetia Awaiting requested review from rghetia

@tedsuo tedsuo Awaiting requested review from tedsuo

Assignees
No one assigned
Labels
area:trace Part of OpenTelemetry tracing pkg:SDK Related to an SDK package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global forwarding Tracer implementation
3 participants
@MrAlias @lizthegrey @jmacd