chore: fix issue with nyc crashing (#1605)

* chore: fix issue with nyc crashing * chore: revert hoist change, make @babel/core nohoist * chore: update @babel/core to test Garbage Collector issue * chore: bump typescripts to 4.4.4 in some package * Revert "chore: bump typescripts to 4.4.4 in some package" This reverts commit 5bf1bfb. * Revert "Revert "chore: bump typescripts to 4.4.4 in some package"" This reverts commit 2877b7e. * Fix cancelled issue --------- Co-authored-by: Haddas Bronfman <85441461+haddasbronfman@users.noreply.github.com>
open-telemetry · Aug 10, 2023 · a1243ee · a1243ee
1 parent 154b30b
commit a1243ee
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 7 deletions.
diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml
@@ -10,6 +10,9 @@ jobs:
       fail-fast: false
       matrix:
         node: ["14", "16", "18"]
+        include:
+            - node: 14
+              code-coverage: true
     runs-on: ubuntu-latest
     services:
       memcached:
@@ -146,12 +149,16 @@ jobs:
         run: npm install --ignore-scripts
       - name: Bootstrap Dependencies
         run: npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --nohoist='mocha' --nohoist='ts-mocha'
-      - name: Unit tests
+      - name: Unit tests (Full)
+        if: matrix.code-coverage
+        run: npm run test -- ${{ matrix.lerna-extra-args }}
+      - name: Unit tests (Delta)
+        if: ${{ !matrix.code-coverage }}
         run: npm run test:ci:changed -- ${{ matrix.lerna-extra-args }}
       - name: Build examples
         run: npm run compile:examples
       - name: Report Coverage
-        if: matrix.node == '14'
+        if: ${{ matrix.code-coverage && !cancelled()}}
         uses: codecov/codecov-action@v3
         with:
           verbose: true

diff --git a/metapackages/auto-instrumentations-web/package.json b/metapackages/auto-instrumentations-web/package.json
@@ -33,7 +33,7 @@
     "@opentelemetry/api": "^1.3.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.0",
+    "@babel/core": "7.22.9",
     "@opentelemetry/api": "^1.3.0",
     "@types/mocha": "8.2.3",
     "@types/node": "18.16.19",

diff --git a/plugins/web/opentelemetry-instrumentation-document-load/package.json b/plugins/web/opentelemetry-instrumentation-document-load/package.json
@@ -50,7 +50,7 @@
     "@opentelemetry/api": "^1.3.0"
   },
   "devDependencies": {
-    "@babel/core": "7.15.0",
+    "@babel/core": "7.22.9",
     "@opentelemetry/api": "^1.3.0",
     "@types/mocha": "8.2.3",
     "@types/node": "18.16.19",

diff --git a/plugins/web/opentelemetry-instrumentation-long-task/package.json b/plugins/web/opentelemetry-instrumentation-long-task/package.json
@@ -47,7 +47,7 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.15.0",
+    "@babel/core": "7.22.9",
     "@opentelemetry/api": "^1.3.0",
     "@opentelemetry/sdk-trace-base": "^1.8.0",
     "@types/jquery": "3.5.16",

diff --git a/plugins/web/opentelemetry-instrumentation-user-interaction/package.json b/plugins/web/opentelemetry-instrumentation-user-interaction/package.json
@@ -47,7 +47,7 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.15.0",
+    "@babel/core": "7.22.9",
     "@opentelemetry/api": "^1.3.0",
     "@opentelemetry/context-zone-peer-dep": "^1.8.0",
     "@opentelemetry/instrumentation-xml-http-request": "^0.41.0",

diff --git a/plugins/web/opentelemetry-plugin-react-load/package.json b/plugins/web/opentelemetry-plugin-react-load/package.json
@@ -47,7 +47,7 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.15.0",
+    "@babel/core": "7.22.9",
     "@opentelemetry/api": "^1.0.0",
     "@opentelemetry/propagator-b3": "^1.3.1",
     "@types/mocha": "7.0.2",