Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect): Skip update HTTP's span name and update RpcMetadata's route instead #1534

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

chigia001
Copy link
Contributor

@chigia001 chigia001 commented Jun 14, 2023

Which problem is this PR solving?

Each framework has a different approach to updating Span's name and HTTP_ROUTE attribute. We want to delegate this to instrumentation-http for consistent's name and attribute
This PR fixes the above issue for connect

Short description of the changes

  • Skip modifying HTTP's Span name directly in instrumentation-connect code
  • Update route property of RpcMetadata

@chigia001 chigia001 requested a review from a team June 14, 2023 09:03
@chigia001 chigia001 force-pushed the fix-1381-connect branch 4 times, most recently from 8b2a9d2 to 295b506 Compare June 17, 2023 07:09
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #1534 (1212769) into main (f7c4324) will decrease coverage by 0.47%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
- Coverage   96.13%   95.67%   -0.47%     
==========================================
  Files          14       18       +4     
  Lines         906     1087     +181     
  Branches      197      221      +24     
==========================================
+ Hits          871     1040     +169     
- Misses         35       47      +12     
Impacted Files Coverage Δ
...try-instrumentation-connect/src/instrumentation.ts 98.76% <100.00%> (ø)

... and 3 files with indirect coverage changes

…oute instead

Signed-off-by: Chi Ma <chigia001@gmail.com>
@Flarna
Copy link
Member

Flarna commented Jun 20, 2023

please avoid forced push as it makes review harder. Just merge main into your branch to keep it up to date. Merge to main will do a squash anyway.

@chigia001
Copy link
Contributor Author

@Flarna seem like there something wrong with last run, it fail at docker pull step.

@Flarna
Copy link
Member

Flarna commented Jun 23, 2023

@open-telemetry/javascript-maintainers Could someone please take a look on this as connect instrumentation lacks a maintainer but I think this change is useful.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this - happy to see this behavior aligned with the other instrumentations 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants