Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document merge reqiurements #1553

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 29, 2023

Which problem is this PR solving?

  • until now, we did implicitly apply the same merge requirements from https://github.com/open-telemetry/opentelemetry-js in this repository. However, some concepts are not considered in the original merge requirements: component lifecycle and component ownership.

Short description of the changes

  • adds the pull request merge requirements from https://github.com/open-telemetry/opentelemetry-js to this repository's CONTRIBUTING.md
  • amends the merge requirements to consider component ownership
  • clarifies that merge requirements apply to all components, regardless of of their current stage in the component lifecycle

fyi @open-telemetry/javascript-maintainers

@pichlermarc pichlermarc requested a review from a team June 29, 2023 06:19
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #1553 (033868f) into main (784a422) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1553   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files          14       14           
  Lines         914      914           
  Branches      199      199           
=======================================
  Hits          878      878           
  Misses         36       36           

@haddasbronfman haddasbronfman merged commit a18b074 into open-telemetry:main Jul 6, 2023
13 checks passed
@pichlermarc pichlermarc deleted the docs/add-merge-requirements branch July 6, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants