Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update grafana/grafana docker tag to v10 #1674

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 8, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
grafana/grafana major 9.0.1 -> 10.2.0

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team September 8, 2023 01:58
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1674 (7e97c05) into main (ea73a67) will decrease coverage by 4.64%.
The diff coverage is n/a.

❗ Current head 7e97c05 differs from pull request most recent head 5ea7a74. Consider uploading reports for the commit 5ea7a74 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   96.06%   91.42%   -4.64%     
==========================================
  Files          14      143     +129     
  Lines         914     7301    +6387     
  Branches      199     1460    +1261     
==========================================
+ Hits          878     6675    +5797     
- Misses         36      626     +590     

see 129 files with indirect coverage changes

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change is probably ok, it would be best to run this example package manually once to verify it still works with the new tag.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blumamir I tired it out but couldn't get traces to show up in jaeger. I don't think this is related to updating grafana though, more likely that there's some misconfiguration in the example. 🤔

@blumamir
Copy link
Member

@blumamir I tired it out but couldn't get traces to show up in jaeger. I don't think this is related to updating grafana though, more likely that there's some misconfiguration in the example. 🤔

Thanks for testing.
I guess we can merge this PR and maybe you can open an issue for the examples not working?

@pichlermarc
Copy link
Member

pichlermarc commented Nov 13, 2023

@blumamir I tired it out but couldn't get traces to show up in jaeger. I don't think this is related to updating grafana though, more likely that there's some misconfiguration in the example. 🤔

Thanks for testing. I guess we can merge this PR and maybe you can open an issue for the examples not working?

Let's do that. #1795 🙂

@renovate-bot renovate-bot force-pushed the renovate/grafana-grafana-10.x branch 2 times, most recently from a12a8d2 to 7e97c05 Compare November 13, 2023 17:04
@pichlermarc pichlermarc merged commit eee50d8 into open-telemetry:main Nov 14, 2023
12 checks passed
@renovate-bot renovate-bot deleted the renovate/grafana-grafana-10.x branch November 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pkg:instrumentation-mysql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants