Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add non-releasing packages to release-please config so their local deps get bumped #1928

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Feb 7, 2024

This is option 1 from #1917.

Closes: #1917

@trentm trentm self-assigned this Feb 7, 2024
@trentm trentm requested a review from a team February 7, 2024 21:14
@trentm trentm changed the title chore: add unreleasing packages to release-please config so their local deps get bumped chore: add non-releasing packages to release-please config so their local deps get bumped Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Merging #1928 (d5c3334) into main (7895306) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1928   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         146      146           
  Lines        7478     7478           
  Branches     1497     1497           
=======================================
  Hits         6807     6807           
  Misses        671      671           

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might also need to add it to the manifest file

scripts/check-release-please.mjs Outdated Show resolved Hide resolved
@trentm
Copy link
Contributor Author

trentm commented Feb 9, 2024

I think you might also need to add it to the manifest file

My initial naive guess was that with skip-github-release: true for these packages that we would not need to add these to the manifest. That was from @pichlermarc's comments here: #1917 (comment)
and the docs on skip-github-release here: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#configfile

FWIW, here is a --dry-run run of release-please ... release-pr: https://gist.github.com/trentm/b1a08cdc264b20e054e282d58f719825
I'm not sure from the copious output whether that is a successful test. It didn't blow up on not having the new packages in the manifest at least. However, I ran it against my fork, so it may be of limited value.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of this 👍

@pichlermarc
Copy link
Member

I think you might also need to add it to the manifest file

My initial naive guess was that with skip-github-release: true for these packages that we would not need to add these to the manifest. That was from @pichlermarc's comments here: #1917 (comment) and the docs on skip-github-release here: https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#configfile

I also think that should be fine if we don't add these to the manifest file. Let's try without it, adding it later should be an easy fix if it's needed.

@pichlermarc pichlermarc merged commit cf034c8 into open-telemetry:main Feb 13, 2024
16 checks passed
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Feb 14, 2024
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Feb 14, 2024
…in release-please release PRs

This continues on from open-telemetry#1928. The non-releasing packages are being added to the
release-please manifest in the hope that this prevents them from being listed
in the set of released packages in a release-please PR. This is
effectively Option 1b from open-telemetry#1917.
pichlermarc added a commit that referenced this pull request Feb 15, 2024
…in release-please release PRs (#1939)

This continues on from #1928. The non-releasing packages are being added to the
release-please manifest in the hope that this prevents them from being listed
in the set of released packages in a release-please PR. This is
effectively Option 1b from #1917.

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Feb 21, 2024
pichlermarc pushed a commit that referenced this pull request Feb 27, 2024
* chore: remove the non-publishing packages from the npm workspace

Because they cause difficulties with updating `@opentelemetry/*` dependencies.
This is "Option 3" from #1917

Refs: #1917

* undo #1917 option 1 work (adding non-publishing packages to release-please config) from #1928

* move express example (haven't adjusted build / docs yet)

* express example updates to get it working

* remove non-publishing packages from release-please manifest

* move koa example

* fix up the koa-example-related files

* move the mongodb/examples files to the top-level

* fixup the mongodb-example files

* move mysql-example files

* fixup the mysql-example files

* move redis-example files to top level examples/ dir

* fixup redis-example files

* update examples README to no longer suggest moving to instruemtnation package dirs

* regenerate package-lock.json to rm the '.../examples' dir entries

'npm install --package-lock-only' did not accomplish this.
This regen was necessary because those vestigial entries caused
surprising breakage in some 'npm install --no-save ...' commands
such as TAV is doing. It broke TAV tests with mongodb@4.17.1.

* compile:examples is no longer a thing

* fix for 'npm ci' failures imported from PR #1955

* regenerate package-lock.json

'undici-types', required by the version of @types/node used
by the new instrumentation-perf-hooks, was lost in the merge
from main.

* add some more test output information to try to help debug flaky test

* fix tweaks to the test

* undo the instr-perf-hooks test assert tweaks, leaving that to a separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updating @opentelemetry/* deps is currently problematic
3 participants