Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detector-aws): suppress internal tracing for all detectors #2433

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

  • AWS detectors perform some HTTP request and fs operations to get metadata. We should suppress the tracing for them

ref: #2320

Short description of the changes

  • suppress tracing in all detectors that need it
  • add a test for all detectors. By doing only one test we avoid some issues with several SDK instantiations within the same process

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (dfb2dff) to head (e4352d1).
Report is 240 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2433      +/-   ##
==========================================
- Coverage   90.97%   90.73%   -0.24%     
==========================================
  Files         146      156      +10     
  Lines        7492     7688     +196     
  Branches     1502     1578      +76     
==========================================
+ Hits         6816     6976     +160     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...ctor-aws/src/detectors/AwsBeanstalkDetectorSync.ts 96.42% <100.00%> (ø)
...e-detector-aws/src/detectors/AwsEc2DetectorSync.ts 98.21% <100.00%> (ø)
...e-detector-aws/src/detectors/AwsEcsDetectorSync.ts 97.11% <100.00%> (ø)
...e-detector-aws/src/detectors/AwsEksDetectorSync.ts 91.86% <100.00%> (ø)

... and 76 files with indirect coverage changes

@pichlermarc pichlermarc merged commit aa9710f into open-telemetry:main Sep 17, 2024
21 checks passed
@dyladan dyladan mentioned this pull request Sep 13, 2024
@david-luna david-luna deleted the dluna/2320-aws-detectors-suppress-tracing branch September 23, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants