Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instrumentation-mysql2): improve performance of getSpanName using substring #2470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

instrumentation-mysql: add tests on getSpanName

81e955b
Select commit
Loading
Failed to load commit list.
Open

refactor(instrumentation-mysql2): improve performance of getSpanName using substring #2470

instrumentation-mysql: add tests on getSpanName
81e955b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2024 in 0s

90.53% (-0.21%) compared to 25ab243

View this Pull Request on Codecov

90.53% (-0.21%) compared to 25ab243

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (25ab243) to head (81e955b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2470      +/-   ##
==========================================
- Coverage   90.74%   90.53%   -0.21%     
==========================================
  Files         156       99      -57     
  Lines        7723     5092    -2631     
  Branches     1588     1008     -580     
==========================================
- Hits         7008     4610    -2398     
+ Misses        715      482     -233     
Files with missing lines Coverage Δ
...e/opentelemetry-instrumentation-mysql/src/utils.ts 97.82% <100.00%> (+0.09%) ⬆️

... and 57 files with indirect coverage changes