chore: changing all env params to be required (#1328)

open-telemetry · Jul 21, 2020 · 3bf4e54 · 3bf4e54
1 parent 2d71b3a
commit 3bf4e54
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/opentelemetry-core/src/platform/browser/environment.ts b/packages/opentelemetry-core/src/platform/browser/environment.ts
@@ -24,7 +24,7 @@ import {
 /**
  * Gets the environment variables
  */
-export function getEnv(): ENVIRONMENT {
+export function getEnv(): Required<ENVIRONMENT> {
   const _window = window as typeof window & ENVIRONMENT_MAP;
   const globalEnv = parseEnvironment(_window);
   return Object.assign({}, DEFAULT_ENVIRONMENT, globalEnv);

diff --git a/packages/opentelemetry-core/src/platform/node/environment.ts b/packages/opentelemetry-core/src/platform/node/environment.ts
@@ -24,7 +24,7 @@ import {
 /**
  * Gets the environment variables
  */
-export function getEnv(): ENVIRONMENT {
+export function getEnv(): Required<ENVIRONMENT> {
   const processEnv = parseEnvironment(process.env as ENVIRONMENT_MAP);
   return Object.assign({}, DEFAULT_ENVIRONMENT, processEnv);
 }
diff --git a/packages/opentelemetry-core/src/utils/environment.ts b/packages/opentelemetry-core/src/utils/environment.ts
@@ -35,7 +35,7 @@ const ENVIRONMENT_NUMBERS: Partial<keyof ENVIRONMENT>[] = [
 /**
  * Default environment variables
  */
-export const DEFAULT_ENVIRONMENT: ENVIRONMENT = {
+export const DEFAULT_ENVIRONMENT: Required<ENVIRONMENT> = {
   OTEL_NO_PATCH_MODULES: '',
   OTEL_LOG_LEVEL: LogLevel.ERROR,
   OTEL_SAMPLING_PROBABILITY: 1,