fix(http): remove outgoing headers normalization

open-telemetry · Jan 23, 2023 · 3f203e3 · 3f203e3
1 parent 9589d54
commit 3f203e3
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 19 deletions.
diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -10,6 +10,8 @@ All notable changes to experimental packages in this project will be documented
 
 ### :bug: (Bug Fix)
 
+* fix(http) Remove outgoing headers normalization [#3557](https://github.com/open-telemetry/opentelemetry-js/pull/3557) @marcinjahn
+
 ### :books: (Refine Doc)
 
 ### :house: (Internal)

diff --git a/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts b/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts
@@ -276,14 +276,6 @@ export const getRequestInfo = (
     origin = `${optionsParsed.protocol || 'http:'}//${hostname}`;
   }
 
-  const headers = optionsParsed.headers ?? {};
-  optionsParsed.headers = Object.keys(headers).reduce(
-    (normalizedHeader, key) => {
-      normalizedHeader[key.toLowerCase()] = headers[key];
-      return normalizedHeader;
-    },
-    {} as OutgoingHttpHeaders
-  );
   // some packages return method in lowercase..
   // ensure upperCase for consistency
   const method = optionsParsed.method

diff --git a/...rimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts b/...rimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts
@@ -508,11 +508,6 @@ describe('HttpInstrumentation', () => {
               'user-agent': testValue,
             },
           }),
-          httpRequest.get(`${protocol}://${hostname}:${serverPort}`, {
-            headers: {
-              'uSeR-aGeNt': testValue,
-            },
-          }),
         ]);
         const spans = memoryExporter.getFinishedSpans();
         assert.strictEqual(spans.length, 0);

diff --git a/...imental/packages/opentelemetry-instrumentation-http/test/functionals/https-enable.test.ts b/...imental/packages/opentelemetry-instrumentation-http/test/functionals/https-enable.test.ts
@@ -459,12 +459,7 @@ describe('HttpsInstrumentation', () => {
             headers: {
               'user-agent': testValue,
             },
-          }),
-          httpsRequest.get(`${protocol}://${hostname}:${serverPort}`, {
-            headers: {
-              'uSeR-aGeNt': testValue,
-            },
-          }),
+          })
         ]);
         const spans = memoryExporter.getFinishedSpans();
         assert.strictEqual(spans.length, 0);