Skip to content

Commit

Permalink
test(sdk-trace-base): pin core.hrtime dependencies on timeOrigin (#2768)
Browse files Browse the repository at this point in the history
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
  • Loading branch information
legendecas and vmarchaud authored Mar 1, 2022
1 parent def9ba3 commit 9579106
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
2 changes: 1 addition & 1 deletion karma.webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = {
target: 'web',
output: { filename: 'bundle.js' },
resolve: { extensions: ['.ts', '.js'] },
devtool: 'inline-source-map',
devtool: 'eval-source-map',
module: {
rules: [
{ test: /\.ts$/, use: 'ts-loader' },
Expand Down
14 changes: 12 additions & 2 deletions packages/opentelemetry-sdk-trace-base/test/common/Span.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,32 @@ import {
SpanContext,
SpanKind,
TraceFlags,
HrTime,
} from '@opentelemetry/api';
import {
DEFAULT_ATTRIBUTE_COUNT_LIMIT,
DEFAULT_ATTRIBUTE_VALUE_LENGTH_LIMIT,
hrTime,
hrTimeDuration,
hrTimeToMilliseconds,
hrTimeToNanoseconds,
otperformance as performance,
} from '@opentelemetry/core';
import { SemanticAttributes } from '@opentelemetry/semantic-conventions';
import * as assert from 'assert';
import * as sinon from 'sinon';
import { BasicTracerProvider, Span, SpanProcessor } from '../../src';

const performanceTimeOrigin = hrTime();
const performanceTimeOrigin: HrTime = [1, 1];

describe('Span', () => {
beforeEach(() => {
sinon.stub(performance, 'timeOrigin')
.value(hrTimeToMilliseconds(performanceTimeOrigin));
});
afterEach(() => {
sinon.restore();
});

const tracer = new BasicTracerProvider({
spanLimits: {
attributeValueLengthLimit: 100,
Expand Down

0 comments on commit 9579106

Please sign in to comment.