Fix lint warnings

[mayurkale22]

After #892 is merged, we see many warnings in the lint build. It would be nice if we can exclude or fix them.

The current lint logs looks very noisy and taking care of a new lint issue can be a daunting task in the future, especially for the new contributors.

Screenshot:

Link: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-js/3706/workflows/82bf0bf2-c125-4663-a3b7-2396167d09cd/jobs/20435/parallel-runs/0/steps/0-105

/cc @OlivierAlbertini

[rezakrimi]

I see that most of them aren't really fixable (like use of any or not using all parameters when implementing interfaces). Is it okay to just make eslint to ignore certain rules on those parts of the code?

[mayurkale22]

I see that most of them aren't really fixable (like use of any or not using all parameters when implementing interfaces). Is it okay to just make eslint to ignore certain rules on those parts of the code?

Sounds reasonable to me. @dyladan WDYT?

[dyladan]

I think that's fine in many cases. A lot of these rules have configs that allow you to ignore cases where the linting rules commonly fail also so that might be worth looking into.

[dyladan]

The other option is to use the --silent option when running lint, which ignores warnings. The advantage of this over marking it as ignored is that it will still highlight issues in your editor, which can help you catch common mistakes. Think this might be a case-by-case decision type of task.

[rezakrimi]

We can make eslint ignore specific rules as well. For instance, we can disable no-unused-vars rule like this:

/* eslint-disable @typescript-eslint/no-unused-vars */
... code that violates rule ...
/* eslint-enable @typescript-eslint/no-unused-vars */

This way we can still catch errors using the linter, even in the ignored section.

[AndrewGrachov]

Regarding unused vars:

Actually, there are a lot of code which mocks real one, like NoopExporter and so on. These params are needed to not break consistency between components,
There could be a convention to omit such parameters, like prefixing them with underscore

https://eslint.org/docs/rules/no-unused-vars#argsignorepattern

[AndrewGrachov]

have time to fix that

[svetlanabrennan]

Should this issue remain open if the above prs fixed some lint warnings?

I do see about 65 lint warning (as of today) when I run it in main. Should we consider fixing those or are we accepting those lint warnings?

[legendecas]

I think it is still valuable to fix the warnings.

[mannyistyping]

@dyladan 👋🏽 I am curious, will this issue remain forever-opened?

Running the lint script I see no issues/warnings popping up

[legendecas]

Lint warnings are not emitted when running with lerna. You can run lerna run --verbose lint to find all the warnings.

[mannyistyping]

Thank you for that guidance! I look forward to helping to reduce those warnings :)

[dyladan]

Closing in favor of #4258