Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-trace-web): fix lint warnings #2451

Merged

Conversation

alisabzevari
Copy link
Contributor

related to #1093,

Which problem is this PR solving?

  • This PR fixes lint warnings in sdk-trace-web package.

Short description of the changes

  • Fix lint warnings

@alisabzevari alisabzevari requested a review from a team September 3, 2021 08:46
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2451 (9f96623) into main (58bfe25) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 9f96623 differs from pull request most recent head 7ed72e2. Consider uploading reports for the commit 7ed72e2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2451      +/-   ##
==========================================
- Coverage   93.26%   92.88%   -0.38%     
==========================================
  Files         115      105      -10     
  Lines        4645     3978     -667     
  Branches     1036      901     -135     
==========================================
- Hits         4332     3695     -637     
+ Misses        313      283      -30     
Impacted Files Coverage Δ
...telemetry-sdk-trace-web/src/StackContextManager.ts 94.28% <ø> (ø)
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts 100.00% <100.00%> (ø)
packages/opentelemetry-sdk-trace-web/src/utils.ts 94.90% <100.00%> (ø)
...opentelemetry-exporter-trace-otlp-http/src/util.ts
...ation-xml-http-request/src/enums/AttributeNames.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...y-exporter-trace-otlp-http/src/OTLPExporterBase.ts
...pentelemetry-exporter-trace-otlp-http/src/types.ts
...exporter-metrics-otlp-http/src/transformMetrics.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
... and 3 more

@vmarchaud
Copy link
Member

@dyladan It appears the cla is broken, do you know how to fix this ?

@dyladan
Copy link
Member

dyladan commented Nov 15, 2021

/easycla

@dyladan
Copy link
Member

dyladan commented Nov 15, 2021

@vmarchaud ^ like that

@vmarchaud vmarchaud merged commit a58f510 into open-telemetry:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants