Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ECMA support due Angular 10 shows warnings #1253

Closed
philipp-bananaware opened this issue Jun 27, 2020 · 2 comments · Fixed by #2112
Closed

Support ECMA support due Angular 10 shows warnings #1253

philipp-bananaware opened this issue Jun 27, 2020 · 2 comments · Fixed by #2112

Comments

@philipp-bananaware
Copy link

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.

Is your feature request related to a problem? Please describe.

With upgrading my project to Angular 10.0.0 this dependency shows a warning:

WARNING in {project}\node_modules\@azure\storage-blob\dist-esm\src\BlobServiceClient.js depends on @opentelemetry/api. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Describe the solution you'd like

No warning is shown.

Describe alternatives you've considered

My alternative would be to put this into the allowedCommonJsDependencies section of angular.json.

Additional context

Find more information about it here:
https://angular.io/guide/build#configuring-commonjs-dependencies

@xirzec
Copy link

xirzec commented Jun 29, 2020

The request here would be to ship a ESM version of the lib, e.g. using the "module" entrypoint in package.json. This would allow bundlers who support ESM to not need to ingest CommonJS code.

@xirzec
Copy link

xirzec commented Jun 16, 2021

@t2t2 This didn't seem to fix the problem for @opentelemetry/api?

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants