Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples that depends on contrib repo to contrib repo #1812

Closed
obecny opened this issue Jan 12, 2021 · 1 comment
Closed

Move examples that depends on contrib repo to contrib repo #1812

obecny opened this issue Jan 12, 2021 · 1 comment
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@obecny
Copy link
Member

obecny commented Jan 12, 2021

This is to avoid some cross dependency especially during update and also to clean things up
@obecny obecny added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers release:required-for-ga labels Jan 12, 2021
@CptSchnitz CptSchnitz mentioned this issue Jul 15, 2021
Closed
@pichlermarc
Copy link
Member

I think this issue was fixed by #2028
I went though the examples again and it seems like none of them depend on the contrib repository anymore.

@obecny obecny closed this as completed Nov 30, 2021
@pichlermarc pichlermarc mentioned this issue Apr 22, 2022
Closed
6 tasks
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@trentm @pichlermarc
chore(instrumentation-mysql2): drop unneed @types/mysql2 dep (open-te…
434cab2 
…lemetry#1812)

Types are included in 'mysql2' now (as of some 2.x release).

The github:types/mysql2 dependency is problematic for dependabot version updates.
See: open-telemetry/opentelemetry-js-contrib#1806 (comment)

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obecny @pichlermarc