Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sinon Fake Timers to improve and speed up tests #447

Closed
obecny opened this issue Oct 21, 2019 · 1 comment
Closed

Use Sinon Fake Timers to improve and speed up tests #447

obecny opened this issue Oct 21, 2019 · 1 comment
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@obecny
Copy link
Member

obecny commented Oct 21, 2019

https://sinonjs.org/releases/v7.5.0/fake-timers/

Now some unit tests are using setTimeout with for example 1s of waiting. This waiting can be simulated with Sinon Fake Timers and speed up unit tests
@obecny obecny added the bug Something isn't working label Oct 21, 2019
@mayurkale22 mayurkale22 mentioned this issue Nov 7, 2019
Merged
@dyladan dyladan added Discussion Issue or PR that needs/is extended discussion. and removed bug Something isn't working labels Jan 22, 2020
@mhennoch
Copy link
Contributor

Seems like faketimers is used in tests, I have used it at least. So this can be closed? @dyladan @obecny ?

@obecny obecny closed this as completed May 18, 2021
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@svrnm
feat(instrumentation-tls): wrap tls.connect API (open-telemetry#447)
22fab71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@obecny @dyladan @mhennoch