Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken CircleCI docs-deploy job #872

Closed
mayurkale22 opened this issue Mar 18, 2020 · 1 comment · Fixed by #1051
Closed

Broken CircleCI docs-deploy job #872

mayurkale22 opened this issue Mar 18, 2020 · 1 comment · Fixed by #1051
Assignees
@dyladan
Labels
bug Something isn't working

Comments

@mayurkale22
Copy link
Member

As per #730, API docs should get published on the new release but it is broken.

/cc @dyladan
@mayurkale22 mayurkale22 added the bug Something isn't working label Mar 18, 2020
@dyladan dyladan self-assigned this Apr 29, 2020
@dyladan
Copy link
Member

dyladan commented May 13, 2020

This is fixed by #1051

@dyladan dyladan linked a pull request May 13, 2020 that will close this issue
chore: deploy docs using github action #1051
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@rauno56
feat: implement auto-instrumentation for fs (open-telemetry#872)
c3fa161 
* feat: initial patching of the fs sync and cb based functions

* fix: reference the correct arguments

* feat: instrument promise calls

* test: test all variants for few "read" functions

* test: add writeFile tests

* fix: implement unwrapping for promise and async variants

* fix: skip promises tests for 8 and 10

* chore: fix types

* fix: add missing types.ts

* fix: support node 8

* docs: comment member names with the versions they were added in

* refactor: use the same order in wrapping and defining the member lists

* fix: finish moving types to types.ts

* style: fix lint

* docs: provide some docs

* chore: add the global docs and config

* feat: tighten up types around fnNames

* fix: remove codecov

* fix: remove jaeger exporter

* docs: reference the correct type for the hooks in the README

* fix: don't use default value

* chore: clean up comments

* chore: clean up and fix dependencies

* style: remove default config value override

* chore: clean up comments

* fix: make running hooks safe

* feat: pass error to endHook

* refactor: rename "asyc" to "callback"

* refactor: order everything sync->callback->promise

* refactor: use finally where appropriate

* chore: start versioning from 0.1.0

* chore: update deps

* chore: update peerDeps api to the earliest supported

* chore: roll back changes to release-please config

* test: capitalize describes

* feat: suppress tracing for all internal fs calls

* chore: comply with peer-dep-check for now

* test: test tracing in callbacks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: deploy docs using github action dynatrace-oss-contrib/opentelemetry-js
2 participants
@dyladan @mayurkale22