Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require grpc-js instead of grpc in grpc-js example #1364

Merged
merged 2 commits into from
Jul 31, 2020
Merged

fix: require grpc-js instead of grpc in grpc-js example #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da47381
fix: require grpc-js instead of grpc in grpc-js example
Jul 28, 2020
82da108
Merge branch 'master' into 1357-mfix-grpc-js-example
obecny Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/grpc-js/helloworld_grpc_pb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

'use strict';

const grpc = require('grpc');
const grpc = require('@grpc/grpc-js');
const helloworld_pb = require('./helloworld_pb.js');

function serialize_HelloReply(arg) {
Expand Down
9 changes: 5 additions & 4 deletions examples/grpc-js/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const tracer = require('./tracer')(('example-grpc-server'));
// eslint-disable-next-line import/order
const grpc = require('grpc');
const grpc = require('@grpc/grpc-js');

const messages = require('./helloworld_pb');
const services = require('./helloworld_grpc_pb');
Expand All @@ -14,9 +14,10 @@ function startServer() {
// Creates a server
const server = new grpc.Server();
server.addService(services.GreeterService, { sayHello });
server.bind(`0.0.0.0:${PORT}`, grpc.ServerCredentials.createInsecure());
console.log(`binding server on 0.0.0.0:${PORT}`);
server.start();
server.bindAsync(`0.0.0.0:${PORT}`, grpc.ServerCredentials.createInsecure(), () => {
console.log(`binding server on 0.0.0.0:${PORT}`);
server.start();
});
}

function sayHello(call, callback) {
Expand Down