chore: deploy canary releases #1384

dyladan · 2020-08-04T14:18:08Z

This will publish a canary version of opentelemetry js on every merge to master. The canary version can be installed by running npm install @opentelemetry/api@canary, replacing api with the package you wish to install.

codecov · 2020-08-04T14:22:20Z

Codecov Report

Merging #1384 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1384      +/-   ##
==========================================
- Coverage   94.03%   93.77%   -0.26%     
==========================================
  Files         149      149              
  Lines        4322     4322              
  Branches      880      880              
==========================================
- Hits         4064     4053      -11     
- Misses        258      269      +11

Impacted Files	Coverage Δ
...lemetry-exporter-collector/src/transformMetrics.ts	`83.87% <0.00%> (-11.83%)`	⬇️

obecny · 2020-08-04T17:29:33Z

for testing purposes can you trigger this not only on master , unless you have already verified it is working fine ?

markwolff

LGTM Thanks for doing this! Should we rename nightly.yaml to canary.yaml?

dyladan · 2020-08-04T18:05:35Z

for testing purposes can you trigger this not only on master , unless you have already verified it is working fine ?

I verified it the best I could without actually deploying to npm. https://github.com/open-telemetry/opentelemetry-js/runs/945162495?check_suite_focus=true In this action you can see it failed because the publish didn't actually run (missing --yes), but the versions appear to be correct.

mayurkale22 · 2020-08-06T05:53:23Z

Just curious to know, in case of failure do we get any notification or build failure alert ?

dyladan · 2020-08-06T12:28:04Z

Just curious to know, in case of failure do we get any notification or build failure alert ?

I have been getting notified of failed github actions directly in the github notification UI. Maybe I have some setting enabled?

* feat: graceful shutdown for tracing and metrics * fix: wording in test case * fix: typo * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: add callbacks to shutdown methods * fix: merge conflict * simplify meter shutdown code Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: fix one-liner * private function name style fix Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: naming of private member variables * fix: graceful shutdown now works in browser * fix: window event listener will trigger once * fix: modify global shutdown helper functions * fix: remove callback from remove listener args * fix: change global shutdown function names and simplify functionality * fix: add rest of function refactoring and simplification * fix: remove unintended code snippet * fix: refactor naming of listener cleanup function and fix sandbox issue * fix: make global shutdown cleanup local * fix: change interval of MeterProvider collection to ensure it does not trigger through clock * chore: removing _cleanupGlobalShutdownListeners * fix: remove unnecesary trace provider member function * Removing default span attributes (#1342) * refactor(opentelemetry-tracing): removing default span attributes Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing default span attributed from tracer object Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing accidental add to package.json Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com> * feat: add baggage support to the opentracing shim (#918) Co-authored-by: Mayur Kale <mayurkale@google.com> * Add nodejs sdk package (#1187) Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: legendecas <legendecas@gmail.com> Co-authored-by: Mark Wolff <mrw00010@gmail.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> * feat: add OTEL_LOG_LEVEL env var (#974) * Proto update to latest to support arrays and maps (#1339) * chore: 0.10.0 release proposal (#1345) * fix: add missing grpc-js index (#1358) * chore: 0.10.1 release proposal (#1359) * feat(api/context-base): change compile target to es5 (#1368) * Feat: Make ID generator configurable (#1331) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix: require grpc-js instead of grpc in grpc-js example (#1364) Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com> * chore(deps): update all non-major dependencies (#1371) * chore: bump metapackage dependencies (#1383) * chore: 0.10.2 proposal (#1382) * fix: remove unnecesary trace provider member function * refactor(metrics): distinguish different aggregator types (#1325) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * Propagate b3 parentspanid and debug flag (#1346) * feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * feat: Collector Metric Exporter for the Web (#1308) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * Fix issues in TypeScript getting started example code (#1374) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * chore: deploy canary releases (#1384) * fix: protos pull * fix: address marius' feedback * chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier * fix: add documentation and cleanup code * fix: remove async label from shutdown and cleanup test case * fix: update controller collect to return promise * fix: make downsides of disabling graceful shutdown more apparent Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com> Co-authored-by: Aravin <34178459+aravinsiva@users.noreply.github.com> Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com> Co-authored-by: Mayur Kale <mayurkale@google.com> Co-authored-by: Naseem <naseemkullah@gmail.com> Co-authored-by: legendecas <legendecas@gmail.com> Co-authored-by: Mark Wolff <mrw00010@gmail.com> Co-authored-by: Matthew Wear <matthew.wear@gmail.com> Co-authored-by: Naseem <naseem@transit.app> Co-authored-by: Mark Wolff <mark.wolff@microsoft.com> Co-authored-by: Cong Zou <32532612+EdZou@users.noreply.github.com> Co-authored-by: Reginald McDonald <40721169+reggiemcdonald@users.noreply.github.com> Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: srjames90 <srjames@lightstep.com> Co-authored-by: David W <dwitt12345@gmail.com> Co-authored-by: Mick Dekkers <mickdekkersnl@gmail.com>

…pen-telemetry#1384) * fix(instrumentation/aws-lambda): Ensure callback is only called once regardless how many providers are flushed Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Update plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com> * fix lint issue Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> --------- Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

chore: deploy canary releases

d07a0db

dyladan requested review from legendecas, markwolff, mayurkale22, mwear, naseemkullah, obecny, OlivierAlbertini and vmarchaud as code owners August 4, 2020 14:18

markwolff approved these changes Aug 4, 2020

View reviewed changes

dyladan added 2 commits August 4, 2020 14:10

Merge remote-tracking branch 'origin/master' into nightly-deploy

e87a19a

chore: rename nightly.yaml to canary.yaml

90e4fc9

obecny approved these changes Aug 4, 2020

View reviewed changes

markwolff mentioned this pull request Aug 4, 2020

[Monitor] add Pipelines Azure/azure-sdk-for-js#10446

Merged

dyladan added the enhancement New feature or request label Aug 5, 2020

Merge branch 'master' into nightly-deploy

dc9fb6e

mayurkale22 approved these changes Aug 6, 2020

View reviewed changes

Merge branch 'master' into nightly-deploy

2556a1f

dyladan merged commit 19ee3dc into open-telemetry:master Aug 6, 2020

dyladan deleted the nightly-deploy branch August 6, 2020 12:28

jonahrosenblum pushed a commit to jonahrosenblum/opentelemetry-js that referenced this pull request Aug 8, 2020

chore: deploy canary releases (open-telemetry#1384)

ef046b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deploy canary releases #1384

chore: deploy canary releases #1384

dyladan commented Aug 4, 2020

codecov bot commented Aug 4, 2020 •

edited

Loading

obecny commented Aug 4, 2020

markwolff left a comment

dyladan commented Aug 4, 2020

mayurkale22 commented Aug 6, 2020

dyladan commented Aug 6, 2020

chore: deploy canary releases #1384

chore: deploy canary releases #1384

Conversation

dyladan commented Aug 4, 2020

codecov bot commented Aug 4, 2020 • edited Loading

Codecov Report

obecny commented Aug 4, 2020

markwolff left a comment

Choose a reason for hiding this comment

dyladan commented Aug 4, 2020

mayurkale22 commented Aug 6, 2020

dyladan commented Aug 6, 2020

codecov bot commented Aug 4, 2020 •

edited

Loading