Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: env vars for span limit as per specification #1653

Merged

Conversation

jtmalinowski
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • respect span limit env vars
  • new defaults conforming to the spec
  • invalid numbers now matched to closest equivalent instead of the default for a given var

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, quick question though, do we actually enforce those limits ?

@jtmalinowski
Copy link
Contributor Author

@vmarchaud
Copy link
Member

@jtmalinowski Yeah that was my question, thanks for the link !

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, I'll note that this significantly increases the default limits.

  • max events per span was 128; now 1000
  • attributes per span was 32; now 1000
  • links per span was 32; now 1000

It is in line with the environment variable spec, however.

@dyladan dyladan added the enhancement New feature or request label Nov 10, 2020
@dyladan dyladan merged commit b703f9f into open-telemetry:master Nov 10, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants