Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added Amazon EKS Resource Detector #1669

Merged
merged 26 commits into from
Dec 3, 2020

Conversation

KKelvinLo
Copy link
Member

@KKelvinLo KKelvinLo commented Nov 11, 2020

Which problem is this PR solving?

  • Added AWS EKS Resource Detector
  • This is similar to the AWS EKS Resource Detector in Java

Short description of the changes

  • Added functionality of AWS EKS resource detector
  • Added corresponding unit tests for AWS EKS detector

If you can review @dyladan, @anuraaga, thanks a lot!

@KKelvinLo KKelvinLo changed the title Add Amazon EKS Resource Detector Feat: Added Amazon EKS Resource Detector Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #1669 (9fcfb96) into master (781b30f) will decrease coverage by 0.02%.
The diff coverage is 89.87%.

@@            Coverage Diff             @@
##           master    #1669      +/-   ##
==========================================
- Coverage   91.38%   91.35%   -0.03%     
==========================================
  Files         164      165       +1     
  Lines        5059     5138      +79     
  Branches     1048     1056       +8     
==========================================
+ Hits         4623     4694      +71     
- Misses        436      444       +8     
Impacted Files Coverage Δ
...ource-detector-aws/src/detectors/AwsEksDetector.ts 89.74% <89.74%> (ø)
...metry-resource-detector-aws/src/detectors/index.ts 100.00% <100.00%> (ø)

@dyladan dyladan added the enhancement New feature or request label Nov 18, 2020
@KKelvinLo
Copy link
Member Author

@dyladan Hi Daniel, would really appreciate any comments or review of the code when possible thanks!

@KKelvinLo
Copy link
Member Author

@obecny would really appreciate a review and merge if possible, thanks!

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  1. Suppressing instrumentation
  2. I see in some places EKS and in other Eks can you please unify it ?
  3. Just a few minor/Nit things

@obecny
Copy link
Member

obecny commented Dec 3, 2020

@KKelvinLo something wrong either with merge or rebase with latest master I suddenly see here changes which has nothing to do with yr PR.

@KKelvinLo KKelvinLo requested a review from obecny December 3, 2020 00:56
@KKelvinLo
Copy link
Member Author

@obecny Consistencies resolved and rebased master, cheers!

@KKelvinLo KKelvinLo requested a review from obecny December 3, 2020 16:01
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for changes

@dyladan dyladan merged commit 3118aed into open-telemetry:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants