-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable propagators using ENV vars #1929
feat: enable propagators using ENV vars #1929
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1929 +/- ##
==========================================
+ Coverage 92.59% 92.74% +0.15%
==========================================
Files 137 137
Lines 4872 4904 +32
Branches 1005 1012 +7
==========================================
+ Hits 4511 4548 +37
+ Misses 361 356 -5
|
f9932c4
to
71c8d1b
Compare
71c8d1b
to
d2d7d7b
Compare
d2d7d7b
to
d086b9b
Compare
@dyladan @obecny @vmarchaud now that Jaeger is in core we can start relying on it and thinking about merging this. I'm trying to gather early feedback, because I remember last time there were issues raised about API of registering/consuming propagators. Here's my thoughts. Defaults are set per spec ( For
We could argue that if vendor requires code changes to register a propagator then why bother with ENV at all? I think that if we have a concept of I'm unsure how to handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me thanks
OTEL_TRACE_SAMPLER_ARG: '', | ||
OTEL_TRACE_SAMPLER: 'parentbased_always_on', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have nothing to do with propagator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jtmalinowski Thanks for taking the time to finish the PR ! |
I don't see any way to register a propagator at present. |
@jdmarshall would you mind opening an issue to elaborate on your problem instead? thank you! |
Which problem is this PR solving?
Short description of the changes
OTEL_PROPAGATORS
environment variables