Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NET_TRANSPORT IPC attributes #2026

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Mar 18, 2021

Which problem is this PR solving?

Adds missing NET_TRANSPORT IPC semantic convention attributes. Came up as a comment on another PR: open-telemetry/opentelemetry-js-contrib#389 (comment)

Short description of the changes

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #2026 (0ba4721) into main (8fd1391) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0ba4721 differs from pull request most recent head 54f6a70. Consider uploading reports for the commit 54f6a70 to get more accurate results

@@            Coverage Diff             @@
##             main    #2026      +/-   ##
==========================================
- Coverage   92.99%   92.97%   -0.02%     
==========================================
  Files         152      152              
  Lines        5925     5925              
  Branches     1245     1245              
==========================================
- Hits         5510     5509       -1     
- Misses        415      416       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants