Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Move upgrade propagator notes to correct section #2579

Conversation

NathanielRN
Copy link
Contributor

Which problem is this PR solving?

The OTel JS 0.26.0 release notes say that the propagator was renamed in 0.26.0 while the README upgrade guidelines says it was done in 0.25.0.

Short description of the changes

It seems like the release notes are correct in this case so this PR fixes that.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@NathanielRN NathanielRN requested a review from a team November 1, 2021 23:17
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2579 (e32cc90) into main (0d0b668) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2579      +/-   ##
==========================================
- Coverage   93.00%   92.86%   -0.15%     
==========================================
  Files         138      125      -13     
  Lines        5092     4552     -540     
  Branches     1095      972     -123     
==========================================
- Hits         4736     4227     -509     
+ Misses        356      325      -31     
Impacted Files Coverage Δ
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts
...y-sdk-trace-base/src/export/ConsoleSpanExporter.ts
...-sdk-trace-base/src/export/InMemorySpanExporter.ts
...try-sdk-trace-base/src/export/NoopSpanProcessor.ts
...dk-trace-base/src/export/BatchSpanProcessorBase.ts
...y-sdk-trace-base/src/export/SimpleSpanProcessor.ts
...ckages/opentelemetry-sdk-trace-base/src/utility.ts
...ackages/opentelemetry-sdk-trace-base/src/config.ts
packages/opentelemetry-sdk-trace-base/src/enums.ts
...ase/src/platform/node/export/BatchSpanProcessor.ts
... and 3 more

@dyladan dyladan added the document Documentation-related label Nov 2, 2021
README.md Outdated Show resolved Hide resolved
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thx for changes

README.md Outdated Show resolved Hide resolved
@dyladan dyladan changed the title fix: Move upgrade propagator notes to correct section doc: Move upgrade propagator notes to correct section Nov 2, 2021
@obecny obecny merged commit 85d5110 into open-telemetry:main Nov 2, 2021
@NathanielRN NathanielRN deleted the fix--put-upgrade-guide-to-rename-propagator-in-correct-section branch November 5, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants