Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@opentelemetry/propagator-jaeger): support custom baggage prefix #2673

Merged

Conversation

sschegolev
Copy link
Contributor

Which problem is this PR solving?

Adds support custom baggage header prefix to make JaegerPropagator API more flexible.

@sschegolev sschegolev requested a review from a team December 16, 2021 15:02
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #2673 (2442da8) into main (315abae) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2673      +/-   ##
==========================================
- Coverage   92.55%   92.53%   -0.02%     
==========================================
  Files         144      144              
  Lines        5183     5186       +3     
  Branches     1104     1106       +2     
==========================================
+ Hits         4797     4799       +2     
- Misses        386      387       +1     
Impacted Files Coverage Δ
...elemetry-propagator-jaeger/src/JaegerPropagator.ts 100.00% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@sschegolev sschegolev force-pushed the support-custom-baggage-header-prefix branch from fd18720 to 2d12742 Compare December 17, 2021 13:44
@sschegolev sschegolev force-pushed the support-custom-baggage-header-prefix branch from 2d12742 to 9ba00cb Compare December 21, 2021 12:07
@sschegolev sschegolev force-pushed the support-custom-baggage-header-prefix branch from 9ba00cb to 215a045 Compare December 21, 2021 20:12
@dyladan dyladan added the enhancement New feature or request label Dec 27, 2021
@vmarchaud vmarchaud merged commit ddede49 into open-telemetry:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants