-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use api 1.1 in SDKs #2759
fix: use api 1.1 in SDKs #2759
Conversation
Use API 1.1 in SDKs to avoid that SDKs register a TracerProvider,... using an older API then other OTel components. This avoids the version check in API rejecting the use of API 1.1 but a peer may still use 1.0.x.
Codecov Report
@@ Coverage Diff @@
## main #2759 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 159 159
Lines 5444 5444
Branches 1142 1142
=======================================
Hits 5078 5078
Misses 366 366 |
This fixes the current issue in CI but honestly speaking I'm not sure if this is really the way to go. Maybe we should narrow more places or find some other way to ensure a correct mix of versions gets installed. The version dependencies we have now (API, core-stable, core-experimental, contrib which releases packages independent) is getting more and more complex and hard to understand. |
I agree that the matrix is complex but i don't see another way to do it right now :/ |
I'm landing this now as it is blocking our CI services. |
I created a followup issue #2769 |
Which problem is this PR solving?
Fixes #2755
Short description of the changes
Use API 1.1 in SDKs to avoid that SDKs register a TracerProvider,... using an older API then other OTel components.
This avoids the version check in API rejecting the use of API 1.1 but a peer may still use 1.0.x.
Type of change
How Has This Been Tested?
CI was failing before
Checklist: