Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid grpc types dependency #3551

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jan 19, 2023

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #3548
Refs: #3386
Refs: open-telemetry/opentelemetry-js-contrib#1358

Short description of the changes

Avoid a dependency to grpc types by moving the into a internal-types.ts file.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Local compile and look into resulting .d.ts files

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

Avoid a dependency to grpc types by moving the into a internal-types.ts file.
@Flarna Flarna requested a review from a team January 19, 2023 12:41
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! 🙂

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #3551 (2b705a4) into main (b5ef0e4) will decrease coverage by 1.00%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3551      +/-   ##
==========================================
- Coverage   93.80%   92.81%   -1.00%     
==========================================
  Files         249      133     -116     
  Lines        7640     3227    -4413     
  Branches     1589      666     -923     
==========================================
- Hits         7167     2995    -4172     
+ Misses        473      232     -241     
Impacted Files Coverage Δ
api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
.../packages/api-logs/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 78.04% <0.00%> (-17.08%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.74% <0.00%> (-15.26%) ⬇️
...er-metrics-otlp-http/src/OTLPMetricExporterBase.ts 52.27% <0.00%> (-11.37%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
... and 118 more

@pichlermarc
Copy link
Member

Failing test seemed unrelated to this PR (looks like a network connectivity problem); it should be gone after the rebase 🙂

@Flarna
Copy link
Member Author

Flarna commented Jan 24, 2023

@open-telemetry/javascript-maintainers Any chance to move this forward? Currently contrib updates to latest SDK is blocked because of this (see open-telemetry/opentelemetry-js-contrib#1358)

@dyladan
Copy link
Member

dyladan commented Jan 24, 2023

@Flarna i'm back from vacation now i'll get this out asap

@dyladan dyladan merged commit 3670071 into open-telemetry:main Jan 25, 2023
@Flarna Flarna deleted the avoid-grpc-types branch January 25, 2023 13:23
@dyladan dyladan mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc instrumentation requires @grpc/grpc-js types but doesn't depend on it
3 participants