Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ConsoleMetricExporter Should Not Export Shallowly #4522

Merged
merged 3 commits into from
Mar 6, 2024
Merged

fix: ConsoleMetricExporter Should Not Export Shallowly #4522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
690779e
fix: (ConsoleMetricExporter): Increase console log depth to get usefu…
JacksonWeber Mar 3, 2024
d56b4e2
update: add contribution to changelog.
JacksonWeber Mar 3, 2024
467e766
Update CHANGELOG.md
JacksonWeber Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
* fixes a bug where `Meter.createHistogram()` with the advice `explicitBucketBoundaries: []` would throw
* fix(context-zone-peer-dep, context-zone): support zone.js 0.13.x, 0.14.x [#4469](https://github.com/open-telemetry/opentelemetry-js/pull/4469) @pichlermarc
* fixes a bug where old versions of `zone.js` affected by <https://github.com/angular/angular/issues/53507> would be pulled in
* fix(sdk-metrics): increase the depth of the output to the console such that objects in the metric are printed fully to the console [#4522](https://github.com/open-telemetry/opentelemetry-js/pull/4522) @JacksonWeber
JacksonWeber marked this conversation as resolved.
Show resolved Hide resolved

### :books: (Refine Doc)

Expand Down
13 changes: 8 additions & 5 deletions packages/sdk-metrics/src/export/ConsoleMetricExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,14 @@ export class ConsoleMetricExporter implements PushMetricExporter {
): void {
for (const scopeMetrics of metrics.scopeMetrics) {
for (const metric of scopeMetrics.metrics) {
console.dir({
descriptor: metric.descriptor,
dataPointType: metric.dataPointType,
dataPoints: metric.dataPoints,
});
console.dir(
{
descriptor: metric.descriptor,
dataPointType: metric.dataPointType,
dataPoints: metric.dataPoints,
},
{ depth: null }
);
}
}

Expand Down