Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instrumentation-xhr): use exported strings for semantic attr… #4681

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

Prashansa-K
Copy link
Contributor

@Prashansa-K Prashansa-K commented May 6, 2024

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replace SemanticAttributes.* with specific exported strings for xml-http-request instrumentation package.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Refactoring change which removes the use of deprecated SemanticAttributes.*

How Has This Been Tested?

  • Unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated -- NA

…ibutes

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>
@Prashansa-K Prashansa-K requested a review from a team May 6, 2024 06:57
Copy link

linux-foundation-easycla bot commented May 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one nit.

…SE_CONTENT_SIZE to new exported string

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>
@pichlermarc pichlermarc added this pull request to the merge queue Jun 4, 2024
Merged via the queue into open-telemetry:main with commit 315239d Jun 4, 2024
17 of 18 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
open-telemetry#4681)

* refactor(instrumentation-xhr): use exported strings for semantic attributes

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>

* Updated changelog entry with PR id and link

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>

* Changed normal string to template string and replaced old HTTP_RESPONSE_CONTENT_SIZE to new exported string

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>

---------

Signed-off-by: Prashansa Kulshrestha <prashkulshrestha@gmail.com>
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants