Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples/http): use new exported string constants for semconv #4750

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

Zen-cronic
Copy link
Contributor

@Zen-cronic Zen-cronic commented Jun 2, 2024

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example http package

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • npm test (no tests for examples?)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Zen-cronic Zen-cronic requested a review from a team June 2, 2024 22:19
Copy link

linux-foundation-easycla bot commented Jun 2, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@@ -4,7 +4,7 @@ const opentelemetry = require('@opentelemetry/api');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
const { Resource } = require('@opentelemetry/resources');
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just importing it, but it's not used down below at L18

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it! Thank you.

@pichlermarc pichlermarc added this pull request to the merge queue Jun 4, 2024
Merged via the queue into open-telemetry:main with commit 20074d8 Jun 4, 2024
18 checks passed
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
open-telemetry#4750)

* refactor(examples/http): use new exported string constants for semconv

* added changelog entry

* refactor(examples/http): actually use new exported string constants for semconv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants