Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-logs): adapt versions for release #4769

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

pichlermarc
Copy link
Member

Versions in @opentelemetry/sdk-logs were not updated correctly in the release PR (ref #4677).
This PR fixes this before actually releasing.

@pichlermarc pichlermarc requested a review from a team June 5, 2024 15:00
@dyladan
Copy link
Member

dyladan commented Jun 5, 2024

How did that happen? Is the version update script insufficient?

@pichlermarc
Copy link
Member Author

pichlermarc commented Jun 5, 2024

How did that happen? Is the version update script insufficient?

dependencies in package.json were changed in #4629 and did not reference the latest local version (had 0.51.0 vs 0.51.1 which is the latest) so it was not updated to 0.52.0 by lerna. With this change it should be okay again.

Edit: same for the other versions, they were not at the latest patch. If left behind once they will stay left behind until manually updated.

@pichlermarc pichlermarc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into open-telemetry:main with commit c4d3351 Jun 5, 2024
19 of 20 checks passed
@pichlermarc pichlermarc deleted the fix/versions branch June 5, 2024 15:31
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
* chore(sdk-logs): fixup release PR versions

* fixup! chore(sdk-logs): fixup release PR versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants