Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): lock file maintenance #4834

Closed
wants to merge 1 commit into from
Closed

chore(deps): lock file maintenance #4834

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 1, 2024 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team July 1, 2024 01:36
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Jul 1, 2024
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from 5c8c58c to 89eff8a Compare July 3, 2024 14:56
@trentm
Copy link
Contributor

trentm commented Jul 4, 2024

The tsc build is failing with errors like these:

Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.

This is due to the @types/lodash update:

diff -ur node_modules-lodash4.17.5/@types/lodash/package.json node_modules-lodash4.17.6/@types/lodash/package.json
--- node_modules-lodash4.17.5/@types/lodash/package.json	2024-07-03 17:31:16
+++ node_modules-lodash4.17.6/@types/lodash/package.json	2024-07-03 17:30:49
@@ -1,6 +1,6 @@
 {
     "name": "@types/lodash",
-    "version": "4.17.5",
+    "version": "4.17.6",
     "description": "TypeScript definitions for lodash",
     "homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash",
     "license": "MIT",
@@ -55,6 +55,6 @@
     },
     "scripts": {},
     "dependencies": {},
-    "typesPublisherContentHash": "74ebed2e7d6c57a170dd86cb86d1848722ce0a78369151c7ac087d43a7a6e2d5",
-    "typeScriptVersion": "4.7"
+    "typesPublisherContentHash": "7b3079d1429e9e75e2d4c67aa9a96e2b37b73f32ccc26b1d4f25bf72d7b27f0f",
+    "typeScriptVersion": "4.8"
 }
...

Here is the problematic "node_modules/@types/lodash/common/object.d.ts" file: https://gist.github.com/trentm/8cab9003b2d2b1641ddc37192c071d0f#file-object-d-ts-L1026

For example it is failing on:

    type GetFieldTypeOfArrayLikeByKey<T extends unknown[], K> =
        K extends number ? T[K]
        : K extends `${infer N extends number}` ? T[N]
//                                           ^--- failing here
        : K extends keyof T ? T[K] : undefined;

Ugh. Does this mean that our being limited to TypeScript 4.4.4 means that we'll start being unable to take some dependencies with too-new .d.ts syntax? I'm guessing the issue is the infer ... extends ... syntax from https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#improved-inference-for-infer-types-in-template-string-types

@trentm trentm mentioned this pull request Jul 17, 2024
Merged
7 tasks
@dyladan dyladan mentioned this pull request Jul 17, 2024
Open
12 tasks
@pichlermarc pichlermarc mentioned this pull request Aug 9, 2024
Merged
1 task
@pichlermarc
Copy link
Member

The tsc build is failing with errors like these:

Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1026,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1031,46): error TS1005: '?' expected.
Error: node_modules/@types/lodash/common/object.d.ts(1041,46): error TS1005: '?' expected.

This is due to the @types/lodash update:

diff -ur node_modules-lodash4.17.5/@types/lodash/package.json node_modules-lodash4.17.6/@types/lodash/package.json
--- node_modules-lodash4.17.5/@types/lodash/package.json	2024-07-03 17:31:16
+++ node_modules-lodash4.17.6/@types/lodash/package.json	2024-07-03 17:30:49
@@ -1,6 +1,6 @@
 {
     "name": "@types/lodash",
-    "version": "4.17.5",
+    "version": "4.17.6",
     "description": "TypeScript definitions for lodash",
     "homepage": "https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/lodash",
     "license": "MIT",
@@ -55,6 +55,6 @@
     },
     "scripts": {},
     "dependencies": {},
-    "typesPublisherContentHash": "74ebed2e7d6c57a170dd86cb86d1848722ce0a78369151c7ac087d43a7a6e2d5",
-    "typeScriptVersion": "4.7"
+    "typesPublisherContentHash": "7b3079d1429e9e75e2d4c67aa9a96e2b37b73f32ccc26b1d4f25bf72d7b27f0f",
+    "typeScriptVersion": "4.8"
 }
...

Here is the problematic "node_modules/@types/lodash/common/object.d.ts" file: https://gist.github.com/trentm/8cab9003b2d2b1641ddc37192c071d0f#file-object-d-ts-L1026

For example it is failing on:

    type GetFieldTypeOfArrayLikeByKey<T extends unknown[], K> =
        K extends number ? T[K]
        : K extends `${infer N extends number}` ? T[N]
//                                           ^--- failing here
        : K extends keyof T ? T[K] : undefined;

Ugh. Does this mean that our being limited to TypeScript 4.4.4 means that we'll start being unable to take some dependencies with too-new .d.ts syntax? I'm guessing the issue is the infer ... extends ... syntax from https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-8.html#improved-inference-for-infer-types-in-template-string-types

Yes - as discussed offline while talking about SDK 2.0 it's going to be a real problem moving forward. Fortunately here we can remove this dependency as it was actually unused, see #4905

@trentm
Copy link
Contributor

trentm commented Aug 9, 2024

I tried to initiate a rebase/retry of this PR now that #4905 is merged.
I believe https://developer.mend.io/github/open-telemetry/opentelemetry-js/-/job/1a2553f6-269f-47a2-ae67-248a7d571244 was the job, but I don't see any update on this PR. Hrm.

@pichlermarc
Copy link
Member

I tried to initiate a rebase/retry of this PR now that #4905 is merged. I believe https://developer.mend.io/github/open-telemetry/opentelemetry-js/-/job/1a2553f6-269f-47a2-ae67-248a7d571244 was the job, but I don't see any update on this PR. Hrm.

Hmm, yes it does not seem to update for some reason. I'll try to close this and have it re-open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

@dyladan dyladan

@legendecas legendecas

@pichlermarc pichlermarc

@blumamir blumamir

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renovate-bot @trentm @pichlermarc @dyladan @legendecas @blumamir