Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update metrics README #490

Merged
merged 8 commits into from
Nov 27, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Update README

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add labels to these examples as well? (Maybe as a follow-up?)

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #490 into master will increase coverage by 1.93%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   90.35%   92.28%   +1.93%     
==========================================
  Files         149      152       +3     
  Lines        7534     7359     -175     
  Branches      663      649      -14     
==========================================
- Hits         6807     6791      -16     
+ Misses        727      568     -159
Impacted Files Coverage Δ
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 66.66% <0%> (-8.34%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
... and 37 more

@mayurkale22
Copy link
Member Author

@open-telemetry/javascript-approvers Please review

packages/opentelemetry-metrics/README.md Outdated Show resolved Hide resolved
@mayurkale22 mayurkale22 merged commit f7185ab into open-telemetry:master Nov 27, 2019
@mayurkale22 mayurkale22 deleted the metrics_readme branch November 27, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants