-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(exporter-prometheus): replace MetricAttributes to Attributes #4993
refactor(exporter-prometheus): replace MetricAttributes to Attributes #4993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the discussion is happening on the referenced PR updating API versions, but want to clarify here. Because this package already depends on "@opentelemetry/api": "1.9.0"
, this is a refactor that does not depend on that other PR. The reference to the original PR is helpful for discussion. This is one of the changes that can happen inmain
without breaking changes, vs the changes to add to next
that require an update to API version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good % changelog nit 🙂
Thanks for working on this 🙌
CHANGELOG.md
Outdated
@@ -19,6 +19,8 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se | |||
|
|||
### :house: (Internal) | |||
|
|||
* refactor(exporter-prometheus): replace `MetricAttributes` and `MetricAttributeValues` with `Attributes` and `AttributeValues` [#4993](https://github.com/open-telemetry/opentelemetry-js/pull/4993) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this should go into ./experimental/CHANGELOG.md
as we're just modifying a experimental package. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! I've moved the entry
Which problem is this PR solving?
Replaces
MetricsAttributes
andMetricAttributeValues
toAttributes
andAttributeValue
Refs #4175
Short description of the changes
How Has This Been Tested?
Ran the test suite for the exporter