Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install minimal lint & doc deps #508

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 8, 2019

Which problem is this PR solving?

Short description of the changes

This installs only the bare minimum required to run yarn run check and yarn run docs. The reason for the odd lerna exec symlinking is because gts looks for rules packages in the local node modules, and does not look in the global directory.

@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2019

Overall time reduction from 4:28 on the last lint & docs build to 48 seconds.

Full test run reduced from ~9 minutes to ~6 minutes

@codecov-io
Copy link

codecov-io commented Nov 8, 2019

Codecov Report

Merging #508 into master will increase coverage by 0.9%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #508     +/-   ##
=========================================
+ Coverage   91.83%   92.73%   +0.9%     
=========================================
  Files         115      135     +20     
  Lines        5656     6453    +797     
  Branches      521      568     +47     
=========================================
+ Hits         5194     5984    +790     
- Misses        462      469      +7
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/http.ts 97.32% <ø> (ø) ⬆️
packages/opentelemetry-plugin-http/src/utils.ts 100% <100%> (ø) ⬆️
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.23% <100%> (ø) ⬆️
...telemetry-plugin-document-load/src/documentLoad.ts 98.09% <100%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...-plugin-postgres/opentelemetry-plugin-pg/src/pg.ts 91.37% <0%> (ø) ⬆️
... and 23 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mayurkale22 mayurkale22 merged commit f180a77 into open-telemetry:master Nov 11, 2019
@Flarna Flarna deleted the minimal-lint branch December 13, 2019 20:35
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* feat: add responseHook config to redis instrumentation

* fix: lint fix

* feat: add responseHook config to redis instrumentation

* fix: lint fix

* chore(deps): update all non-major dependencies (open-telemetry#483)

* chore: generalize the instrumentation file name (open-telemetry#479)

* feat: add responseHook config to graphql instrumentation

* Apply suggestions from code review

Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>

* test: add a test for a responseHook that isn't a function

* fix: lint fix

Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants