Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default plugins list and fix npm badge #646

Merged
merged 4 commits into from
Jan 2, 2020

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Update default plugins list

  • fix npm badge

@codecov-io
Copy link

codecov-io commented Dec 23, 2019

Codecov Report

Merging #646 into master will decrease coverage by 0.16%.
The diff coverage is 19.23%.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   89.92%   89.75%   -0.17%     
==========================================
  Files         190      215      +25     
  Lines       10169    10126      -43     
  Branches      929      932       +3     
==========================================
- Hits         9144     9089      -55     
- Misses       1025     1037      +12
Impacted Files Coverage Δ
packages/opentelemetry-base/src/version.ts 0% <ø> (ø)
...ges/opentelemetry-scope-async-hooks/src/version.ts 0% <0%> (ø)
packages/opentelemetry-plugin-dns/src/version.ts 0% <0%> (ø)
...kages/opentelemetry-exporter-jaeger/src/version.ts 0% <0%> (ø)
...s/opentelemetry-plugin-mongodb-core/src/version.ts 0% <0%> (ø)
packages/opentelemetry-web/src/version.ts 0% <0%> (ø)
packages/opentelemetry-plugin-http/src/version.ts 0% <0%> (ø)
packages/opentelemetry-plugin-https/src/version.ts 0% <0%> (ø)
packages/opentelemetry-plugin-redis/src/version.ts 0% <0%> (ø)
packages/opentelemetry-metrics/src/version.ts 0% <0%> (ø)
... and 71 more

@mayurkale22 mayurkale22 added this to the Alpha v0.3.2 milestone Dec 23, 2019
@mayurkale22 mayurkale22 added the document Documentation-related label Dec 23, 2019
@dyladan
Copy link
Member

dyladan commented Dec 24, 2019

Maybe we should add ioredis?

@mayurkale22
Copy link
Member Author

Maybe we should add ioredis?

Good call, done.

README.md Show resolved Hide resolved
@dyladan
Copy link
Member

dyladan commented Jan 2, 2020

Can you please add ioredis to the default enabled plugins?

@dyladan dyladan added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jan 2, 2020
@mayurkale22 mayurkale22 merged commit 6c98ab9 into open-telemetry:master Jan 2, 2020
@mayurkale22 mayurkale22 deleted the readme_0.3.1 branch January 2, 2020 21:28
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…pen-telemetry#646)

* feat(koa): Adds config option to allow selected layers to be ignored
* Fixes linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants