Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add protocol for dynamic configuration service #155

Closed
wants to merge 13 commits into from
Closed

[WIP] Add protocol for dynamic configuration service #155

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f2aed90
Add dynamic config protos
May 29, 2020
2010ce4
Refactor dyconfig to dynamicconfig
Jun 1, 2020
b024fe4
Polish dynamicconfig proto
Jun 2, 2020
aa516d0
Add additional documentation
Jun 2, 2020
ab778ca
Modify inclusion-exclusion pattern type
Jun 3, 2020
2c2220f
Tidy message definitions
Jun 4, 2020
cb12eea
Elaborate Schedule documentation
Jun 5, 2020
b6fc2e1
Remove metadata field from request
Jun 5, 2020
42a0f05
Final polish
Jun 5, 2020
5f67555
Tidy documentation comments
Jun 9, 2020
5406581
Clarify fingerprint documentation
Jun 11, 2020
c4b3c95
Restart field numbering
Jun 24, 2020
b686427
Merge with master
Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify fingerprint documentation
  • Loading branch information
wtong98 committed Jun 11, 2020
commit 5406581153f7ff56c8df47588e2a5d8a620a5494
8 changes: 7 additions & 1 deletion gen/go/collector/dynamicconfig/v1/dynamicconfig_service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion opentelemetry/proto/collector/dynamicconfig/v1/dynamicconfig_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ message ConfigRequest{
opentelemetry.proto.resource.v1.Resource resource = 2;

// Optional. The value of ConfigResponse.fingerprint for the last configuration
// a resource received that was successfully applied.
// a resource received, regardless whether it was successfully applied.
bytes last_known_fingerprint = 3;
}

Expand All @@ -51,6 +51,12 @@ message ConfigResponse {
// ConfigRequest.last_known_fingerprint, then all other fields besides
// fingerprint in the response are optional, or the same as the last update if
// present.
//
// The exact mechanics of generating the fingerprint is up to the
// implementation. However, a fingerprint must be deterministically determined
// by the configurations -- the same configuration will generate the same
// fingerprint on any instance of an implementation. Hence using a timestamp is
// unacceptable, but a deterministic hash is fine.
bytes fingerprint = 2;

// Dynamic configs specific to metrics
Expand Down