Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Exemplars from Histogram, will be added later for all points #193

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 4, 2020

Fixes #81

@bogdandrutu bogdandrutu requested review from a team August 4, 2020 22:58
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary change, looks good. I would think we probably need to revisit this alongside raw values (exact aggregation) before declaring the proto stable

@bogdandrutu
Copy link
Member Author

Not planning to declare proto stable now. But definitely we understood that this is not well defined. So prefer to remove it now to remove one blocker from stable proto

@bogdandrutu bogdandrutu merged commit 63f37e5 into open-telemetry:master Aug 5, 2020
@bogdandrutu bogdandrutu deleted the exemplars branch February 1, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HistogramValue.Bucket.Exemplar is inadequate
4 participants