Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop multiple calls to AsyncPGInstrumentor.__init__ from clobbering instance attributes #1791

Merged
merged 11 commits into from
Feb 5, 2024
Merged

Stop multiple calls to AsyncPGInstrumentor.__init__ from clobbering instance attributes #1791

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dfba842
Stop multiple calls to AsyncPGInstrumentor.__init__ from clobbering i…
marcuslimdw Jan 31, 2024
b7f8ab3
Remove class-level initialisation of _tracer
marcuslimdw Jan 31, 2024
d674343
Fix regex
marcuslimdw Jan 31, 2024
57f792d
Merge branch 'main' into marcuslimdw/asyncpg-fix-multiple-instrumento…
marcuslimdw Jan 31, 2024
75ce86a
Merge branch 'main' into marcuslimdw/asyncpg-fix-multiple-instrumento…
srikanthccv Feb 4, 2024
0972b91
Add to changelog
marcuslimdw Feb 5, 2024
6ce6a51
Fix lint errors
marcuslimdw Feb 5, 2024
479e788
Merge remote-tracking branch 'origin/marcuslimdw/asyncpg-fix-multiple…
marcuslimdw Feb 5, 2024
eb5eabe
Update CHANGELOG.md
marcuslimdw Feb 5, 2024
0f9dd37
Set tracer in class definition to avoid lint error
marcuslimdw Feb 5, 2024
6e16268
Merge remote-tracking branch 'origin/marcuslimdw/asyncpg-fix-multiple…
marcuslimdw Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint errors
  • Loading branch information
@marcuslimdw
marcuslimdw committed Feb 5, 2024
commit 6ce6a515368d7500258a5f9686cbb29d20dbee0c
4 changes: 3 additions & 1 deletion instrumentation/opentelemetry-instrumentation-asyncpg/tests/test_asyncpg_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ def test_duplicated_instrumentation_works(self):
first = AsyncPGInstrumentor()
first.instrument()
second = AsyncPGInstrumentor()
self.assertIsNotNone(first._tracer)
second.instrument()
self.assertIsNotNone(first._tracer)
self.assertIsNotNone(second._tracer)

def test_duplicated_uninstrumentation(self):
AsyncPGInstrumentor().instrument()
Expand Down