Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump confluent-kafka-python allowed version #1856

Conversation

rafa-munoz
Copy link
Contributor

@rafa-munoz rafa-munoz commented Jun 12, 2023

Description

According to confluent_kafka's CHANGELOG, v2.0.2, v2.1.0 and v2.1.1 were released without any major changes regarding its API interface usage for both producer and consumer, so it's safe to do the bump to increase compatibility.

OpenSSL 3.0.x upgrade in librdkafka requires a major version bump, as some legacy ciphers need to be explicitly configured to continue working, but it is highly recommended NOT to use them. The rest of the API remains backward compatible.

Type of change

Please delete options that are not relevant.

  • Version compatibility
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Upgrade the version in this library plus confluent-kafka-python's version and see if it works.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rafa-munoz rafa-munoz force-pushed the bump-confluent-kafka-max-version branch from f495aaf to d1866ee Compare June 12, 2023 22:58
@rafa-munoz rafa-munoz requested a review from a team June 12, 2023 22:58
@rafa-munoz rafa-munoz force-pushed the bump-confluent-kafka-max-version branch 4 times, most recently from 16a1691 to 0ce062f Compare June 13, 2023 10:04
@rafa-munoz rafa-munoz force-pushed the bump-confluent-kafka-max-version branch from 0ce062f to 14fcce6 Compare June 13, 2023 10:10
@shalevr
Copy link
Member

shalevr commented Jun 14, 2023

There is already PR for this change #1815

@rafa-munoz rafa-munoz closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants