Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celery duplicated instrumentation #2342

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Celery duplicated instrumentation #2342

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
937c9f7
* Adding (failing) testcase to cover Issue #2029
reiktar Mar 11, 2024
ae97898
* move Instance variables to class variables. Since the object in que…
reiktar Mar 11, 2024
0a2eab1
* black formatting
reiktar Mar 11, 2024
e3439f4
* Changelog stub entry, PR # to follow
reiktar Mar 11, 2024
62e1b4c
* updating the pullrequest number
reiktar Mar 11, 2024
fa61334
* remove superfluous constructor
reiktar Mar 12, 2024
871390a
* moving Change log to unreleased section
reiktar Mar 12, 2024
017d4dd
Merge branch 'main' into celery-duplicated-instrumentation
shalevr Mar 13, 2024
dcaf5c8
Merge branch 'main' into celery-duplicated-instrumentation
shalevr Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* black formatting
  • Loading branch information
@reiktar
reiktar committed Mar 11, 2024
commit 0a2eab14066341d687e0a8fb22f86ed24957dfd1
4 changes: 2 additions & 2 deletions instrumentation/opentelemetry-instrumentation-celery/tests/test_duplicate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

from opentelemetry.instrumentation.celery import CeleryInstrumentor

class TestUtils(unittest.TestCase):

class TestUtils(unittest.TestCase):
def test_duplicate_instrumentaion(self):
first = CeleryInstrumentor()
first.instrument()
Expand All @@ -26,5 +26,5 @@ def test_duplicate_instrumentaion(self):
CeleryInstrumentor().uninstrument()
self.assertIsNotNone(first.metrics)
self.assertIsNotNone(second.metrics)
self.assertEqual(first.task_id_to_start_time,{})
self.assertEqual(first.task_id_to_start_time, {})
self.assertEqual(second.task_id_to_start_time, {})