Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confluent kafka producer poll and flush returns #2527

Merged
merged 9 commits into from
May 30, 2024
Merged

Add confluent kafka producer poll and flush returns #2527

merged 9 commits into from
May 30, 2024

Conversation

dferrochio
Copy link
Contributor

@dferrochio dferrochio commented May 16, 2024

Description

Add return statement to Confluent kafka Producer poll() and flush() calls when instrumented by ConfluentKafkaInstrumentor().instrument_producer()

Fixes #2525

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added unittests for instrumented Confluent kafka producer poll and flush methods.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented May 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@dferrochio dferrochio requested a review from a team May 16, 2024 14:54
@xrmx
Copy link
Contributor

xrmx commented May 17, 2024

@dferrochio You need to sign the CLA

@dferrochio
Copy link
Contributor Author

@xrmx CLA signed

@dferrochio
Copy link
Contributor Author

@oxeye-dorkolog can review?, please

@lzchen lzchen merged commit 41792e7 into open-telemetry:main May 30, 2024
314 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants